feat: non-nullable privacy setting #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eenshot redaction when user accesses it.
vaind
requested review from
krystofwoldrich,
stefanosiano,
buenaflor and
martinhaintz
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/redact-screenshots-via-view-hierarchy #2382 +/- ##
=============================================================================
Coverage ? 85.08%
=============================================================================
Files ? 81
Lines ? 2809
Branches ? 0
=============================================================================
Hits ? 2390
Misses ? 419
Partials ? 0 ☔ View full report in Codecov by Sentry. |
7 tasks
|
@martinhaintz WDYT about these changes to your PR? |
martinhaintz
approved these changes
Nov 11, 2024
vaind
commented
Nov 11, 2024
martinhaintz
approved these changes
Nov 11, 2024
vaind
merged commit 21851d9
into
feat/redact-screenshots-via-view-hierarchy
48 of 50 checks passed
martinhaintz
added a commit
that referenced
this pull request
Nov 24, 2024
* use view hierachy for screenshots * fix tests and distinguish between ScheduledScreenshotRecorderConfig and ScreenshotRecorderConfig. * removed unused imports * remove unused test * add changelog * rename variable * add internal * split into screenshot, screenreplay and redaction options * fix comments * export redaction options and remove unused dependencies * renaming to SentryPrivacyOptions * add explanation for setRedactionOptions * fix deprecation warnings * Update flutter/lib/src/sentry_flutter.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/sentry_flutter.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Update flutter/lib/src/sentry_privacy_options.dart Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * feat: non-nullable privacy setting (#2382) * refactor: make privacy setting non-nullable and automatically set screenshot redaction when user accesses it. * Apply suggestions from code review * formatting * keep recorder instance in memory * Update flutter/lib/src/sentry_screenshot_options.dart Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * update comment for sentry screenshot options * fixed screenshot size mismatch * renamed some variables to make it more readable * fix unit tests * reorganized tests * update changelog * screenshots now also working with canvas kit * Update CHANGELOG.md Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * Update flutter/lib/src/sentry_flutter_options.dart Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * Update flutter/lib/src/sentry_screenshot_options.dart Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * renamed screenshot settings * removed quality from recorder config. * Update CHANGELOG.md Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * Update flutter/lib/src/event_processor/screenshot_event_processor.dart Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * add test for screenshots with flutter html renderer * Update flutter/lib/src/sentry_screenshot_options.dart Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * add changelog for supported html renderer * removed unused import * revert: screenshot recorder resolution handling (#2409) * add high-risk-code file filters * revert: screenshot recorder resolution handling * analyzer issues * chore: update example * improve screenshot recorder logs * fixup variable visibility * dart format --------- Co-authored-by: Martin Haintz <martin.haintz@gmail.com> * fix pixelRatio * Update flutter/test/replay/scheduled_recorder_test.dart Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * fix unit tests * Update flutter/lib/src/screenshot/recorder.dart Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com> * reverted changes for html renderer as it is not working * fix unit tests and errors * add comment for quality * moved code back to previous position * rearrange imports * move screenshot options into global options * change wording from redaction to masking and similar. * add import for screenshot event processor --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suggests a change on top of another PR (#2361) - I think it would be more user-friendly to provide the
options.experimental.privacyas a non-nullable field so users can set its properties directly.See code comments for some more details
#skip-changelog