Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cocoa sdk version updater #2392

Merged
merged 6 commits into from
Nov 7, 2024
Merged

fix: cocoa sdk version updater #2392

merged 6 commits into from
Nov 7, 2024

Conversation

buenaflor
Copy link
Contributor

#skip-changelog

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (bec58b2) to head (1041439).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
+ Coverage   84.72%   84.84%   +0.11%     
==========================================
  Files         254       79     -175     
  Lines        9113     2804    -6309     
==========================================
- Hits         7721     2379    -5342     
+ Misses       1392      425     -967     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.90 ms 462.06 ms 23.16 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8da6ae0 526.18 ms 596.82 ms 70.64 ms
d5fb969 420.83 ms 490.88 ms 70.05 ms
d883d62 330.15 ms 378.48 ms 48.33 ms
66e0270 369.04 ms 431.96 ms 62.92 ms
afa6e2a 349.73 ms 428.48 ms 78.75 ms
09c1f55 449.98 ms 509.38 ms 59.40 ms
9d7e862 426.35 ms 510.88 ms 84.53 ms
6d50a9b 467.98 ms 526.48 ms 58.50 ms
6a5a65d 410.26 ms 503.91 ms 93.65 ms
6a40d32 292.09 ms 350.81 ms 58.73 ms

App size

Revision Plain With Sentry Diff
8da6ae0 6.49 MiB 7.57 MiB 1.08 MiB
d5fb969 6.35 MiB 7.35 MiB 1021.16 KiB
d883d62 6.15 MiB 7.13 MiB 999.97 KiB
66e0270 6.35 MiB 7.35 MiB 1017.84 KiB
afa6e2a 6.27 MiB 7.20 MiB 955.69 KiB
09c1f55 6.49 MiB 7.55 MiB 1.07 MiB
9d7e862 6.33 MiB 7.26 MiB 943.41 KiB
6d50a9b 6.49 MiB 7.55 MiB 1.06 MiB
6a5a65d 6.35 MiB 7.41 MiB 1.05 MiB
6a40d32 6.16 MiB 7.14 MiB 1003.99 KiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

github-actions bot commented Nov 7, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1253.88 ms 1280.76 ms 26.88 ms
Size 8.38 MiB 9.75 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e0f6628 1250.57 ms 1274.86 ms 24.29 ms
3a69405 1292.84 ms 1303.96 ms 11.12 ms
48c3cf1 1239.14 ms 1268.14 ms 28.99 ms
a7acb24 1296.71 ms 1317.69 ms 20.98 ms
464b4d0 1249.02 ms 1261.22 ms 12.20 ms
6f3717a 1259.84 ms 1280.90 ms 21.06 ms
3334ac1 1259.22 ms 1275.40 ms 16.17 ms
cfa25fc 1251.77 ms 1275.69 ms 23.92 ms
8932ece 1234.31 ms 1238.90 ms 4.59 ms
689d2fd 1257.71 ms 1265.16 ms 7.45 ms

App size

Revision Plain With Sentry Diff
e0f6628 8.32 MiB 9.50 MiB 1.18 MiB
3a69405 8.15 MiB 9.15 MiB 1018.56 KiB
48c3cf1 8.38 MiB 9.73 MiB 1.36 MiB
a7acb24 8.16 MiB 9.17 MiB 1.01 MiB
464b4d0 8.10 MiB 9.16 MiB 1.07 MiB
6f3717a 8.33 MiB 9.62 MiB 1.29 MiB
3334ac1 8.10 MiB 9.17 MiB 1.08 MiB
cfa25fc 8.32 MiB 9.43 MiB 1.10 MiB
8932ece 8.29 MiB 9.36 MiB 1.07 MiB
689d2fd 8.10 MiB 9.16 MiB 1.06 MiB

@buenaflor buenaflor merged commit acaa2d3 into main Nov 7, 2024
51 checks passed
@buenaflor buenaflor deleted the fix/updater-cocoa branch November 7, 2024 15:54
martinhaintz added a commit that referenced this pull request Nov 11, 2024
* main:
  release: 8.10.1
  fix: android build error when compiling (#2397)
  release: 8.10.0
  chore: prepare changelog for `8.10.0` release (#2391)
  chore(deps): update Cocoa SDK to v8.40.1 (#2394)
  fix: cocoa sdk version updater (#2392)
  Send Less Client Reports When Rate Limited (#2380)
  build(deps): bump ruby/setup-ruby from 1.197.0 to 1.199.0 (#2386)
  chore(deps): update Native SDK to v0.7.12 (#2390)
  chore(deps): update Android SDK to v7.16.0 (#2373)
  fix build error for latest flutter beta (3.27.0) (#2385)
  Remove duplicate tests in sentry_client_test.dart (#2378)
  Handle backpressure earlier in pipeline (#2371)
  Add screenshot to `SentryFeedbackWidget` (#2369)

# Conflicts:
#	flutter/lib/src/event_processor/screenshot_event_processor.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants