-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: linux crashpad handler path #2443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
==========================================
+ Coverage 87.01% 91.77% +4.76%
==========================================
Files 259 83 -176
Lines 9233 2883 -6350
==========================================
- Hits 8034 2646 -5388
+ Misses 1199 237 -962 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ed2ae08 | 360.06 ms | 440.92 ms | 80.86 ms |
bffc2c5 | 348.00 ms | 399.89 ms | 51.89 ms |
ecb4003 | 332.58 ms | 385.15 ms | 52.57 ms |
b66cc27 | 493.11 ms | 554.66 ms | 61.55 ms |
0bed04d | 382.15 ms | 458.33 ms | 76.18 ms |
09eab47 | 455.30 ms | 478.46 ms | 23.16 ms |
f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
6e9c5a2 | 392.32 ms | 498.51 ms | 106.19 ms |
31b2afb | 397.04 ms | 475.09 ms | 78.04 ms |
7ec9238 | 414.02 ms | 513.94 ms | 99.91 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ed2ae08 | 6.27 MiB | 7.20 MiB | 958.73 KiB |
bffc2c5 | 6.34 MiB | 7.28 MiB | 966.31 KiB |
ecb4003 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
b66cc27 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
0bed04d | 6.33 MiB | 7.30 MiB | 987.71 KiB |
09eab47 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
6e9c5a2 | 6.35 MiB | 7.42 MiB | 1.07 MiB |
31b2afb | 6.34 MiB | 7.28 MiB | 966.36 KiB |
7ec9238 | 6.35 MiB | 7.42 MiB | 1.06 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b29d6e | 1208.18 ms | 1230.92 ms | 22.73 ms |
299a3f6 | 1231.02 ms | 1249.00 ms | 17.98 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
b98109e | 1254.19 ms | 1279.90 ms | 25.71 ms |
7faee57 | 1232.65 ms | 1246.10 ms | 13.45 ms |
d4120ac | 1260.61 ms | 1274.09 ms | 13.47 ms |
3ad66e4 | 1230.44 ms | 1245.08 ms | 14.65 ms |
8e133ad | 1268.19 ms | 1277.37 ms | 9.18 ms |
89ea268 | 1252.33 ms | 1253.58 ms | 1.26 ms |
49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b29d6e | 8.32 MiB | 9.38 MiB | 1.05 MiB |
299a3f6 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
b98109e | 8.10 MiB | 9.17 MiB | 1.08 MiB |
7faee57 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
d4120ac | 8.28 MiB | 9.34 MiB | 1.06 MiB |
3ad66e4 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
8e133ad | 8.10 MiB | 9.16 MiB | 1.07 MiB |
89ea268 | 8.09 MiB | 9.16 MiB | 1.06 MiB |
49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
vaind
requested review from
krystofwoldrich,
stefanosiano,
buenaflor and
martinhaintz
as code owners
November 22, 2024 16:02
buenaflor
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2431
I've removed this in the latest variant of the PR during some merges but turns out it was supposed to stay.
#skip-changelog