Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: remove options.autoAppStart and setAppStartEnd #2680

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 10, 2025

📜 Description

v9 task

💡 Motivation and Context

SDK consistency, and these APIs just make it harder to maintain it.
Users can already disable the integration if they wish to without the autoAppStart flag

💚 How did you test it?

Existing tests are enough since we remove functionality

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor changed the base branch from main to v9 February 10, 2025 22:20
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/integrations/native_app_start_integration.dart

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (3e1c2c9) to head (dd0799c).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2680      +/-   ##
==========================================
+ Coverage   89.06%   92.62%   +3.55%     
==========================================
  Files         261       89     -172     
  Lines        8847     2873    -5974     
==========================================
- Hits         7880     2661    -5219     
+ Misses        967      212     -755     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor requested a review from denrase February 11, 2025 12:55
@buenaflor buenaflor merged commit 0dbb666 into v9 Feb 11, 2025
60 checks passed
@buenaflor buenaflor deleted the v9-task/remove-auto-app-start-api branch February 11, 2025 15:07
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants