-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9]: remove options.autoAppStart
and setAppStartEnd
#2680
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9 #2680 +/- ##
==========================================
+ Coverage 89.06% 92.62% +3.55%
==========================================
Files 261 89 -172
Lines 8847 2873 -5974
==========================================
- Hits 7880 2661 -5219
+ Misses 967 212 -755 ☔ View full report in Codecov by Sentry. |
📜 Description
v9 task
💡 Motivation and Context
SDK consistency, and these APIs just make it harder to maintain it.
Users can already disable the integration if they wish to without the
autoAppStart
flag💚 How did you test it?
Existing tests are enough since we remove functionality
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps