Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: Enable privacy masking for screenshots by default #2728

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 18, 2025

📜 Description

Enable privacy masking for screenshots by default

💡 Motivation and Context

Closes #2640

💚 How did you test it?

Existing tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (75e3eba) to head (544237e).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2728      +/-   ##
==========================================
+ Coverage   88.50%   89.73%   +1.23%     
==========================================
  Files         262       91     -171     
  Lines        8758     2952    -5806     
==========================================
- Hits         7751     2649    -5102     
+ Misses       1007      303     -704     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase denrase marked this pull request as ready for review February 18, 2025 12:46
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@denrase denrase merged commit 7c468df into v9 Feb 18, 2025
61 checks passed
@denrase denrase deleted the v9-enable-privacy-masking-by-default branch February 18, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants