Skip to content

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 13, 2025

📜 Description

Part of JNI/FFI refactorings:

💡 Motivation and Context

Partly completes #3204

💚 How did you test it?

Manual, integration tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

@buenaflor buenaflor changed the title Enh/ffi jni set user Refactor: use FFI/JNI for setUser Oct 13, 2025
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.84%. Comparing base (b82a031) to head (5ef5a4a).

Files with missing lines Patch % Lines
.../flutter/lib/src/native/sentry_native_channel.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           enh/ffi-jni-breadcrumbs-sync    #3295      +/-   ##
================================================================
+ Coverage                         88.08%   88.84%   +0.76%     
================================================================
  Files                               294      279      -15     
  Lines                             10199     9657     -542     
================================================================
- Hits                               8984     8580     -404     
+ Misses                             1215     1077     -138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review October 13, 2025 14:51
cursor[bot]

This comment was marked as outdated.

@buenaflor buenaflor requested a review from denrase October 14, 2025 10:49
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants