Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate list of links with "Platform or SDK doesn't support this" #3107

Closed
bruno-garcia opened this issue Feb 16, 2021 · 8 comments · Fixed by #5835
Closed

Generate list of links with "Platform or SDK doesn't support this" #3107

bruno-garcia opened this issue Feb 16, 2021 · 8 comments · Fixed by #5835

Comments

@bruno-garcia
Copy link
Member

We display documentation by default which requires opting out, such notSupported=platform.
This results in accidental additions such as User Feedback for Unity: #3100

This request is for a list of link that include such blocks:
image

The goal is to address them by properly rendering the page or the block conditionally to the platform supporting it.
@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@PeloWriter
Copy link
Contributor

Enabling an SDK feature list to be a source of truth would also fix this issue.

@bruno-garcia
Copy link
Member Author

We'd still need to change all parts of the doc that reference some content without any guard for to whether there's code snippet for the generated platform or not.

The original idea of this issue was to get a list of pages that we show on a platform for which we don't have a code snippet for it, so we could address it.

@smeubank smeubank mentioned this issue Oct 21, 2021
Closed
@untitaker
Copy link
Member

Is there a legitimate usecase for showing this error on a page without guarding the surrounding content? If no I would lean towards cleaning up all existing platformcontent uses and making the build fail if this alert would make it into the output

@untitaker
Copy link
Member

@bruno-garcia if you still feel like auditing this, here's a list of files that might need to be fixed

$ rg -i 'if you think this is an error' -l -thtml
platforms/go/guides/iris/configuration/filtering/index.html
platforms/go/guides/http/configuration/filtering/index.html
platforms/go/guides/gin/configuration/filtering/index.html
platforms/go/guides/negroni/configuration/filtering/index.html
platforms/go/guides/martini/configuration/filtering/index.html
platforms/go/guides/echo/configuration/filtering/index.html
platforms/go/guides/fasthttp/configuration/filtering/index.html
platforms/native/performance/index.html
platforms/unreal/enriching-events/attachments/index.html
platforms/native/guides/qt/performance/index.html
platforms/unreal/data-management/debug-files/upload/index.html
platforms/go/configuration/filtering/index.html
platforms/unity/configuration/sampling/index.html
platforms/dotnet/configuration/sampling/index.html
platforms/dotnet/guides/nlog/configuration/sampling/index.html
platforms/dotnet/guides/uwp/data-management/debug-files/upload/index.html
platforms/dotnet/guides/maui/data-management/debug-files/upload/index.html
platforms/dotnet/guides/uwp/configuration/sampling/index.html
platforms/dotnet/guides/maui/configuration/sampling/index.html
platforms/dotnet/guides/nlog/data-management/debug-files/upload/index.html
platforms/dotnet/guides/serilog/configuration/sampling/index.html
platforms/dotnet/guides/wpf/data-management/debug-files/upload/index.html
platforms/dotnet/guides/serilog/data-management/debug-files/upload/index.html
platforms/dotnet/guides/xamarin/data-management/debug-files/upload/index.html
platforms/dotnet/guides/xamarin/configuration/sampling/index.html
platforms/dotnet/guides/winforms/data-management/debug-files/upload/index.html
platforms/dotnet/guides/wpf/configuration/sampling/index.html
platforms/dotnet/guides/winforms/configuration/sampling/index.html
platforms/dotnet/guides/google-cloud-functions/configuration/sampling/index.html
platforms/dotnet/guides/google-cloud-functions/data-management/debug-files/upload/index.html
platforms/dotnet/guides/extensions-logging/configuration/sampling/index.html
platforms/dotnet/guides/aspnet/data-management/debug-files/upload/index.html
platforms/dotnet/guides/log4net/configuration/sampling/index.html
platforms/dotnet/guides/log4net/data-management/debug-files/upload/index.html
platforms/dotnet/guides/extensions-logging/data-management/debug-files/upload/index.html
platforms/dotnet/guides/aws-lambda/configuration/sampling/index.html
platforms/dotnet/guides/aspnet/configuration/sampling/index.html
platforms/dotnet/guides/entityframework/data-management/debug-files/upload/index.html
platforms/dotnet/guides/entityframework/configuration/sampling/index.html
platforms/dotnet/guides/aws-lambda/data-management/debug-files/upload/index.html
platforms/dotnet/guides/aspnetcore/configuration/sampling/index.html
platforms/dotnet/guides/aspnetcore/data-management/debug-files/upload/index.html
platforms/dotnet/data-management/debug-files/upload/index.html
platforms/unity/data-management/debug-files/upload/index.html
platforms/rust/usage/sdk-fingerprinting/index.html
platforms/rust/guides/actix-web/enriching-events/identify-user/index.html
platforms/rust/guides/actix-web/usage/sdk-fingerprinting/index.html
platforms/rust/enriching-events/identify-user/index.html
platforms/rust/guides/actix-web/enriching-events/breadcrumbs/index.html
platforms/rust/enriching-events/breadcrumbs/index.html
platforms/rust/guides/actix-web/enriching-events/scopes/index.html
platforms/rust/enriching-events/scopes/index.html
platforms/rust/guides/actix-web/configuration/releases/index.html
platforms/rust/configuration/sampling/index.html
platforms/rust/configuration/filtering/index.html
platforms/rust/guides/actix-web/configuration/sampling/index.html
platforms/rust/guides/actix-web/configuration/filtering/index.html
platforms/rust/configuration/releases/index.html
platforms/elixir/enriching-events/identify-user/index.html
platforms/elixir/enriching-events/breadcrumbs/index.html
platforms/elixir/usage/sdk-fingerprinting/index.html
platforms/elixir/usage/set-level/index.html
platforms/elixir/enriching-events/scopes/index.html
platforms/apple/guides/tvos/data-management/debug-files/upload/index.html
platforms/apple/guides/macos/data-management/debug-files/upload/index.html
platforms/apple/guides/watchos/data-management/debug-files/upload/index.html
platforms/apple/guides/ios/data-management/debug-files/upload/index.html
platforms/apple/data-management/debug-files/upload/index.html
platforms/elixir/configuration/draining/index.html
platforms/elixir/configuration/filtering/index.html

@bruno-garcia bruno-garcia mentioned this issue Nov 9, 2022
Merged
@bruno-garcia
Copy link
Member Author

Opened a PR (#5752) to address .NET
Could ask @bitsandfoxes or @tustanivsky to help with Unreal's platforms/unreal/data-management/debug-files/upload/index.html ,
and @philipphofmann or @brustolin with apple's platforms/apple/data-management/debug-files/upload/index.html

@philipphofmann philipphofmann mentioned this issue Nov 15, 2022
Closed
@philipphofmann
Copy link
Member

I created an issue for Cocoa #5783

@untitaker untitaker mentioned this issue Nov 22, 2022
Merged
@tustanivsky tustanivsky mentioned this issue Dec 1, 2022
Closed
@tustanivsky
Copy link
Collaborator

Added an issue for UE #169

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(platform content): Hide pages and sections with missing snippets getsentry/sentry-docs
5 participants
@untitaker @bruno-garcia @philipphofmann @tustanivsky @PeloWriter