Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an SDK feature list to become source of truth #39

Open
bruno-garcia opened this issue Feb 10, 2021 · 8 comments
Open

Support an SDK feature list to become source of truth #39

bruno-garcia opened this issue Feb 10, 2021 · 8 comments

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Feb 10, 2021

The goal is for SDKs to report their feature set via the release registry. Adding features to the registry can become part of the developer workflow (i.e add a features.yaml to the repo root and craft appends to the registry).

The goals

  • Remove sheets with manually mapped feature matrix. And to have a generated page listing SDKs and the features they support.
  • Remove manually maintained supported/notSupported docs guards for features.
  • Define the exact version a feature was introduced. So the docs can point it out.
  • Maintain the feature list in the SDK repository, next to the code, maintained by the SDK owners.

Some examples/proposed features and which SDKs support it include:

  • ui.user-feedback: A UI to collect user feedback.
    • JavaScript Browser
  • api.user-feedback: The API for users to fill out a user feedback received with their own UI
    • Android, Java, .NET, Apple
  • api.attachment: The API to attach a file to events
    • Android, Java, .NET, Native, Python
  • api.session-tracking: Can report release health through session tracking.
  • api.null-annotated: For technologies with optional support for Null Safety
  • auto.session-tracking: Sends session data automatically.
  • options.name: Where name is the actual property name documented here.

Follow up with @PeloWriter about consuming this in the docs.

@BYK
Copy link
Member

BYK commented Feb 11, 2021

So getsentry/sentry#23585 essentially needs this feature to be completed.

@bruno-garcia can I assign that PR to you or is there another point person for this work?

@bruno-garcia
Copy link
Member Author

We are not able to schedule this right now so it needs to stay unassigned.
Unless you want to pick it up? :)

@BYK
Copy link
Member

BYK commented Feb 15, 2021

We are not able to schedule this right now so it needs to stay unassigned.
Unless you want to pick it up? :)

No, thank you my plate is quite full and I don't think I have full context around this yet.

I'd rather add Status: On Hold to indicate we want to work on this but not yet to prevent it from being closed by stale bot.

@PeloWriter
Copy link

This would be very useful for our customers.

@PeloWriter
Copy link

PeloWriter commented Mar 3, 2021

The goal here is to programmatically answer the question "does this SDK support this feature?" which would ensure the content is correct and current. We would then also link to associated content (configuration, product guide, or third-party, for example).

Here's one example (from React Native):

Features:

@PeloWriter
Copy link

PeloWriter commented Mar 11, 2021

@bruno-garcia - can we get a definitive list of all possible features to get this started?

My suggestion (to start):

  • User Feedback
  • Attachments
  • Minidumps
  • Performance (included/custom as level of support)
  • Breadcrumbs
  • Release Health
  • (free form - integration support)

@bruno-garcia
Copy link
Member Author

I wonder if we can have a "link to examples" as a feature?
For example, in the sentry-react-native repo we'd have:

  - example-url: "https://github.com/getsentry/examples/tree/master/react-native"

@bruno-garcia
Copy link
Member Author

Related prior work: getsentry/sentry-java#1527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants