fix(ui): Use the correct docs link for user feedback docs #23585
Conversation
Turns out there was an information architecture change over at getsentry/sentry-docs recently, requiring a platform name for the docs of user feedback. This patch tries to fix that. Fixes #23551.
| @@ -108,7 +108,9 @@ class UserFeedbackEmpty extends React.Component<Props> { | |||
| eventName: 'User Feedback Docs Clicked', | |||
| }) | |||
| } | |||
| href="https://docs.sentry.io/enriching-error-data/user-feedback/" | |||
| href={`https://docs.sentry.io/platforms/${ | |||
| this.props.projects[0].platform || 'javascript' | |||
There was a problem hiding this comment.
In case there are no projects
| this.props.projects[0].platform || 'javascript' | |
| this.props.projects?.[0].platform || 'javascript' |
There was a problem hiding this comment.
I don't think we can reach this line if projects is an empty array due to the check above. Am I missing something?
|
Verified the fix with the Vercel preview, it works. Added a small fix regarding selected projects on user feedback view. Also /cc @PeloWriter & @dcramer to prevent similar things in the future. We may want to set up alerts on number of 404s on the docs. |
|
Doesn't seem like platforms always matches up to docs? e.g. https://docs.sentry.io/platforms/javascript-react/enriching-events/user-feedback/ |
Ugh, good catch. I need the parent platform id. I'll see if this is easy to get, otherwise I just need good ol' |
|
@billyvg ugh, so not only my hacky Here's what I think:
|
|
Can we extrapolate support? We list the platforms that don't support User Feedback in the yaml frontmatter of |
|
It would be good to find a more automated fix. We've also got breakage for the link in Settings > Tags "add custom tags" |
|
Going to remove myself from reviewers, feel free to re-tag me if there are updates |
|
@evanpurkhiser since you did #23720 recently, I need your eyes on this. |
|
Should we just drop trying to incorporate the platform key? |
I mean, wouldn't it be nice to take them directly where they should be going instead of introducing another hop? I think the missing link here is, if the platform does not support this, it should take you to the platform selection page instead of giving you a 404. Or we should fetch that information and not display this link/page at all (see getsentry/sentry-release-registry#39 for that part) |
Turns out there was an information architecture change over at getsentry/sentry-docs recently, requiring a platform name for the docs of user feedback. This patch tries to fix that. Fixes #23551.