Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/mimi js page #1043

Merged
merged 18 commits into from
Jun 7, 2019
Merged

Update/mimi js page #1043

merged 18 commits into from
Jun 7, 2019

Conversation

MimiDumpling
Copy link
Contributor

@MimiDumpling MimiDumpling commented Jun 4, 2019 •
edited
Loading

Updating the JavaScript SDK pages with some suggestions that were recently made.

untitaker
untitaker reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftr, this looks fine to me structurally but I don't have a lot of expertise on the js ecosystem. I think the structure would work well for python.

dcramer
dcramer approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@dcramer dcramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just clean up PR description/title and ship it.

@MimiDumpling MimiDumpling changed the title WIP Update/mimi js page Update/mimi js page Jun 7, 2019
@MimiDumpling MimiDumpling merged commit 73eb19b into master Jun 7, 2019
@evanpurkhiser evanpurkhiser deleted the update/mimi-js-page branch June 10, 2019 22:02
evanpurkhiser
evanpurkhiser reviewed Jun 10, 2019
View reviewed changes
src/collections/_documentation/platforms/javascript/index.md
You should `init` the Sentry Browser SDK as soon as possible during your page load:

``` javascript
Sentry.init({ dsn: 'https://<key>@sentry.io/<project>' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wny not use the __PUBLIC_DSN__ here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanpurkhiser is that recommended? All of our "Getting Started" docs have this format. I just want to make sure we're using the proven/good/recommended way.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dcramer dcramer dcramer approved these changes

@untitaker untitaker untitaker left review comments

@evanpurkhiser evanpurkhiser evanpurkhiser left review comments

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MimiDumpling @dcramer @untitaker @evanpurkhiser