Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apple): Mention not creating TTID/TTFD spans #10960

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

philipphofmann
Copy link
Member

DESCRIBE YOUR PR

Explain why the SDK doesn't create TTID/TTFD spans when the app is in the background.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Explain why the SDK doesn't create TTID/TTFD spans when the app is in
the background.
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 0:05am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 0:05am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 0:05am

Copy link

codecov bot commented Aug 2, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.25MB 6 bytes ⬇️
sentry-docs-edge-server 253.05kB 3 bytes ⬇️
sentry-docs-client 6.24MB 6 bytes ⬇️

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question for clarification, otherwise LGTM, thanks!

philipphofmann and others added 4 commits August 7, 2024 11:42
…instrumentation.mdx

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
…instrumentation.mdx

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
…instrumentation.mdx

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
…instrumentation.mdx

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@philipphofmann philipphofmann merged commit e40d520 into master Aug 8, 2024
9 checks passed
@philipphofmann philipphofmann deleted the fix/apple-no-ttid-ttfd-when-in-background branch August 8, 2024 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants