feat(native): update contexts interface to flatten distribution keys #11936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
JoshuaMoelans
commented
Nov 25, 2024
JoshuaMoelans
commented
Nov 25, 2024
JoshuaMoelans
added a commit
to getsentry/relay
that referenced
this pull request
Nov 28, 2024
…4292) (continuation of #3443 ) <!-- Describe your PR here. --> To make these fields searchable, we had to change from a nested to a flattened approach. This is provided in sentry-native ([relevant PR](getsentry/sentry-native#963)). The update is also tracked on the docs side: getsentry/sentry-docs#11936
JoshuaMoelans
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 28, 2024
<!-- Describe your PR here. --> update to #69865 To search the distribution fields, we cannot have them in a hierarchy `os.distribution.name`, we instead need them flattened to `os.distribution_name` This is part of reworking the following native-SDK PR: getsentry/sentry-native#963 The update is also tracked on the docs side: getsentry/sentry-docs#11936 And on Relay: getsentry/relay#4292
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Dec 2, 2024
<!-- Describe your PR here. --> update to #69865 To search the distribution fields, we cannot have them in a hierarchy `os.distribution.name`, we instead need them flattened to `os.distribution_name` This is part of reworking the following native-SDK PR: getsentry/sentry-native#963 The update is also tracked on the docs side: getsentry/sentry-docs#11936 And on Relay: getsentry/relay#4292
supervacuus
approved these changes
Dec 4, 2024
JoshuaMoelans
deleted the
feat/native_distribution_context_update_Joshua
branch
Lms24
pushed a commit
that referenced
this pull request
Dec 13, 2024
…11936) * Updated distribution keys to flattened versions * link to native main branch + os-release dos * Change links to relevant Options entry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
In reference to getsentry/sentry-native#963 ; we need to flatten the payload so the values are properly searchable.
ToDo:
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES