Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for sentry-ruby changes #12455

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

frederikspang
Copy link
Contributor

DESCRIBE YOUR PR

Updates example for sample rate, to match PR for getsentry/sentry-ruby#2403 - That means that we now follow "correct" Sentry op.name queue.process, instead of custom sidekiq.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jan 24, 2025

@frederikspang is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) January 27, 2025 13:05
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 11:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 11:05pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 11:05pm

@sl0thentr0py sl0thentr0py merged commit 6c9f1f1 into getsentry:master Jan 27, 2025
11 checks passed
jan-auer added a commit that referenced this pull request Jan 28, 2025
…zation-settings

* master: (511 commits)
  docs(cloudflare): several semantic and stylistic fixes in code examples for cloudflare workers (#12482)
  chore(replay): Clarify network bandwidth and show how to reduce perf impact for mobile SDKs (#12479)
  chore(replay): Update product docs FAQ (#12474)
  ref: Drop remaining usage of `<Note>` (#12476)
  Update debugmeta.mdx (#12436)
  Fix queue_producer_transaction string termination error in example code (#12463)
  Adjust for sentry-ruby changes (#12455)
  Fixed incorrect instrument.mjs filename (#12454)
  Updating feature flags docs location (#12453)
  ref: Remove `<Note>` component in favor of using `<Alert>` (#12467)
  feat: send content feedback plausible events (#12400)
  docs(native): document how to set attribute on spans/transactions
  feat(express): Add warning about express v5 (#12465)
  chore(jira): Add instructions for installing Jira for self-hosted sentry users (#12433)
  chore: Update Codecov Bundler Plugin Version (#12459)
  Bump API schema to 421589ca (#12461)
  fix(platform): Enable scrolling via keyboard buttons (#12460)
  feat: Update `Expandable` style (#12457)
  Add Kotlin examples and fix typo in Java and Android Scopes docs (#12458)
  doc(js): Document how to set attribute on all spans (#12449)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants