Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elixir): Add sentence about before_send_event returning nil #1293

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

lobsterkatie
Copy link
Member

getsentry/sentry-elixir#364 (which fixes getsentry/sentry-elixir#363) brings the Elixir SDK's before_send_event config option in line with other, similar config options (beforeSend and before_send) in the unified SDKs, in that it now recognizes a falsy return value as a signal to drop the event. This PR adds a sentence explaining that behavior to the Elixir config docs.

Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lobsterkatie
Copy link
Member Author

@mitchellhenke - can't tag you as a reviewer, but would appreciate you taking a glance anyway.

@mitchellhenke
Copy link
Contributor

👍 👍

@lobsterkatie lobsterkatie merged commit 3d8a350 into master Oct 24, 2019
@lobsterkatie lobsterkatie deleted the kmclb-elixir-before-send-event branch October 24, 2019 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Use before_send_event for filtering
3 participants