Skip to content

Conversation

@bruno-garcia
Copy link
Member

We should do a rename on all of the docs for CaptureUserFeedback since the API is deprecated.

@jamescrosswell does this overload exist? I quickly looked the API and it takes UserFeedback as an argument.
Calling CaptureFeedback(new Feedback is pretty cumbersome

@vercel
Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 5:22pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 5:22pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 5:22pm

@codeowner-assignment codeowner-assignment bot requested a review from a team May 22, 2025 00:37
@codecov
Copy link

codecov bot commented May 22, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.2MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/x93EVXPtvTx6Q4bJUOqUq/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/x93EVXPtvTx6Q4bJUOqUq/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/1ZWSzIFcwAT99e4nJ2NpN/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/1ZWSzIFcwAT99e4nJ2NpN/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@jamescrosswell
Copy link
Collaborator

Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
@bruno-garcia bruno-garcia enabled auto-merge (squash) May 23, 2025 17:06
@bruno-garcia
Copy link
Member Author

Thanks James

@bruno-garcia bruno-garcia merged commit 0312e40 into master May 23, 2025
13 checks passed
@bruno-garcia bruno-garcia deleted the bruno-garcia-patch-6 branch May 23, 2025 23:40
antonpirker pushed a commit that referenced this pull request Jun 6, 2025
We should do a rename on all of the docs for `CaptureUserFeedback` since
the API is deprecated.

@jamescrosswell does this overload exist? I quickly looked the API and
it takes `UserFeedback` as an argument.
Calling `CaptureFeedback(new Feedback` is pretty cumbersome

---------

Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants