feat(python): Add 3.x version of span metrics page #14477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 594 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
sl0thentr0py
approved these changes
Jul 29, 2025
lucas-zimerman
pushed a commit
that referenced
this pull request
Jul 29, 2025
Adding a 3.x version of the Span Metrics page. The contents are
identical except for changing 2.x-style `set_data()` to 3.x-style
`set_attribute()`.
Since the 3.x page is a brand new file, it shows up all green on the
diff. This is the actual difference between the old page and the new
`index__v3.x.mdx` page:
```diff
--- index.mdx 2025-07-21 14:06:41
+++ index__v3.x.mdx 2025-07-28 09:44:24
@@ -23,11 +23,11 @@
span = sentry_sdk.get_current_span()
if span:
# Add individual metrics
- span.set_data("database.rows_affected", 42)
- span.set_data("cache.hit_rate", 0.85)
- span.set_data("memory.heap_used", 1024000)
- span.set_data("queue.length", 15)
- span.set_data("processing.duration_ms", 127)
+ span.set_attribute("database.rows_affected", 42)
+ span.set_attribute("cache.hit_rate", 0.85)
+ span.set_attribute("memory.heap_used", 1024000)
+ span.set_attribute("queue.length", 15)
+ span.set_attribute("processing.duration_ms", 127)
### Best Practices for Span Data
@@ -48,11 +48,11 @@
name="Database Query Metrics"
) as span:
# Set metrics after creating the span
- span.set_data("db.query_type", "SELECT")
- span.set_data("db.table", "users")
- span.set_data("db.execution_time_ms", 45)
- span.set_data("db.rows_returned", 100)
- span.set_data("db.connection_pool_size", 5)
+ span.set_attribute("db.query_type", "SELECT")
+ span.set_attribute("db.table", "users")
+ span.set_attribute("db.execution_time_ms", 45)
+ span.set_attribute("db.rows_returned", 100)
+ span.set_attribute("db.connection_pool_size", 5)
# Your database operation here
pass
```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a 3.x version of the Span Metrics page. The contents are identical except for changing 2.x-style
set_data()to 3.x-styleset_attribute().Since the 3.x page is a brand new file, it shows up all green on the diff. This is the actual difference between the old page and the new
index__v3.x.mdxpage:Direct link to preview: https://sentry-docs-git-ivana-pythonupdate-span-metrics-page-for-3x.sentry.dev/platforms/python/tracing/span-metrics__v3.x
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES