-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(dotnet/logs): add Logs for the .NET SDK #14583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Oh it's draft, sorry I might have jumped the gun tagging @AbhiPrasad and @cleptric here |
Bundle ReportChanges will increase total bundle size by 3.75kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
/> | ||
- <LinkWithPlatformIcon | ||
platform="dotnet.maui" | ||
label="MAUI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to put this under the ### Mobile
header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want to move it into Mobile
... but we could imagine copying it there as well ... but we're uncertain about the duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Worth mentioning structured logs in the Overview of the features for the Microsoft.Extensions.Logging integration I think: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I think for .NET we could emphasise usage via ILogger
(since this is so ubiquitous in .NET and how the vast majority of SDK users will want to create logs).
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
DESCRIBE YOUR PR
Add documentation for Sentry Structed Logs for
dotnet
.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES