Skip to content

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Oct 7, 2025

DESCRIBE YOUR PR

The changes were already made in this PR: getsentry/sentry-react-native#5221

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@alwx alwx requested a review from antonis October 7, 2025 11:54
@alwx alwx self-assigned this Oct 7, 2025
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 7, 2025 0:59am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 7, 2025 0:59am

@codeowner-assignment codeowner-assignment bot requested a review from a team October 7, 2025 11:54
@antonis antonis requested a review from lucas-zimerman October 7, 2025 11:59
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change look good and consistent with the changes in getsentry/sentry-react-native#5221

Given that the fix above changes the behavior for all RN versions should we also update the scripts for older versions?

Let's also wait for the release of getsentry/sentry-react-native#5221 before merging.

Copy link

codecov bot commented Oct 7, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.15MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.96MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/vLQkQaH1oQQgpF53sOIvN/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/vLQkQaH1oQQgpF53sOIvN/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/6JYh1l9cxnntdAGypVcTR/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/6JYh1l9cxnntdAGypVcTR/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%

@codeowner-assignment codeowner-assignment bot requested a review from a team October 7, 2025 12:16
@alwx
Copy link
Contributor Author

alwx commented Oct 7, 2025

@antonis yes, I've just pushed changes that will update the scripts for older versions as well.
And yes, we have to wait until the merged PR is released.

@Brma1048
Copy link

Brma1048 commented Oct 7, 2025

@alwx When you create a fresh react native project it is "$REACT_NATIVE_PATH/scripts..." instead of "../node_modules/scripts..."

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the preview side. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants