Skip to content

Conversation

chargome
Copy link
Member

@chargome chargome commented Oct 8, 2025

@chargome chargome requested a review from onurtemizkan October 8, 2025 14:01
@chargome chargome self-assigned this Oct 8, 2025
Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 8, 2025 2:35pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Oct 8, 2025 2:35pm

Comment on lines +191 to +193
sentry-cli sourcemaps inject /path/to/build/dir
# Upload sourcemaps
sentry-cli sourcemaps upload /path/to/build/dir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: Incorrect documentation for source map path leads to silent upload failure
  • Description: The documentation for Hydrogen with React Router provides an incorrect and generic placeholder path (/path/to/build/dir) for the sentry-cli sourcemaps inject command. The correct path for Hydrogen projects is the dist directory. Using the incorrect path will cause the CLI command to fail silently, leading to source maps not being uploaded and resulting in un-symbolicated stack traces for production errors.

  • Suggested fix: Update the documentation to use the correct, specific build directory for Hydrogen, which is dist. For example: sentry-cli sourcemaps inject ./dist.
    severity: 0.7, confidence: 0.9

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link

codecov bot commented Oct 8, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.15MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.96MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/q48ge2Y6iromYpSDwJV3t/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/q48ge2Y6iromYpSDwJV3t/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants