-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix (docs) Render integartions inside highlight block #15388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 9.14kB (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
|
Lms24
approved these changes
Nov 4, 2025
codyde
added a commit
that referenced
this pull request
Nov 5, 2025
…ntry/sentry-docs into docs/span-metrics-examples * 'docs/span-metrics-examples' of https://github.com/getsentry/sentry-docs: (29 commits) chore: Rename 404 lint job (#15403) Update prevent Discord link (#15402) fix incorrect urls (#15400) fix: Typos (#15401) feat(replay): Add screenshotStrategy option for React Native (#15334) docs(sdks): New Span API (#11939) fix (docs) Render integartions inside highlight block (#15388) fix(python): `mcp.transport` correct values (#15394) docs(limits): Update docs to match new size limits for events/attachments (#15395) Fix typos across file types & add automation (#15385) Fix 404 linter (#15312) feat(billing): Updated invoice terms to receipts and bills (#15374) fix: Update GitHub app URL from apps/sentry-io to /apps/sentry (#15386) fix(billing): Correct billing-related actions for roles (#15370) Document global attributes (#15279) docs(godot): Update before-send examples (#15306) docs(godot): User Feedback UI (aka widget) (#15304) fix(python): Remove memcached references (#15380) feat(native): external crash reporter (#15244) docs(self-hosted): provide more insights on troubleshooting kafka (#15131) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix integrations wrapper visibility in code blocks with line highlighting
Problem
The integrations array wrapper (
integrations: [and],) wasn't showing/hiding correctly in the Vue quickstart and other guides that use line highlighting syntax (e.g.,{3, 12-41}).Root Cause
When code blocks have line highlighting, the
makeHighlightBlocksfunction wraps highlighted lines in<HighlightBlock>components. This changed the DOM structure so that lines were no longer direct children of the<code>element, but nested inside containers.The runtime logic in
updateElementsVisibilityForOptionsassumed lines were direct children, causingallLines.indexOf(openLine)to return-1and breaking the wrapper show/hide logic.Solution
Added a
getAllCodeLineshelper function that properly traverses the code block structure, extracting lines from both:This ensures the integrations wrapper visibility logic works correctly regardless of whether the code block uses line highlighting.
Files Changed
src/components/onboarding/index.tsx- Added helper to handle nested line structure in highlighted code blocksIS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES