-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: Add missing supabaseIntegration docs for deno, cloudflare and react-native #15397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| Sentry.init({ | ||
| dsn: 'YOUR_DSN', | ||
| integrations: [ | ||
| Sentry.browserTracingIntegration(), | ||
| Sentry.supabaseIntegration({ supabaseClient }) | ||
| ], | ||
| tracesSampleRate: 1.0, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, we just want to show how the integration should be added to any Sentry.init call.
Bundle ReportChanges will increase total bundle size by 1.05kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending react-native changes from @alwx.
|
@andreiborza done |
a4b8032 to
3a2c999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Sentry Import Causes ReferenceError in Diff
The code example is missing the Sentry import statement. The diff removed import * as Sentry from '@sentry/browser'; to make it platform-agnostic, but didn't add a generic Sentry import to replace it. The code now uses Sentry.init() and Sentry.supabaseIntegration() without importing Sentry, which would cause a ReferenceError.
docs/platforms/javascript/common/configuration/integrations/supabase.mdx#L43-L56
sentry-docs/docs/platforms/javascript/common/configuration/integrations/supabase.mdx
Lines 43 to 56 in 3a2c999
| ```javascript | |
| import { createClient } from '@supabase/supabase-js'; | |
| const supabaseClient = createClient('YOUR_SUPABASE_URL', 'YOUR_SUPABASE_KEY'); | |
| Sentry.init({ | |
| dsn: 'YOUR_DSN', | |
| integrations: [ | |
| Sentry.supabaseIntegration({ supabaseClient }) | |
| ], | |
| tracesSampleRate: 1.0, | |
| }); | |
| ``` |
| Sentry.init({ | ||
| dsn: 'YOUR_DSN', | ||
| integrations: [ | ||
| Sentry.browserTracingIntegration(), | ||
| Sentry.supabaseIntegration({ supabaseClient }) | ||
| ], | ||
| tracesSampleRate: 1.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Supabase integration documentation code example is missing the Sentry import, leading to a ReferenceError.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The code example for Supabase integration in docs/platforms/javascript/common/configuration/integrations/supabase.mdx (lines 42-54) is missing the import * as Sentry from '@sentry/browser'; statement. This omission causes any code following the example to throw a ReferenceError: Sentry is not defined when Sentry.init() or Sentry.supabaseIntegration() are called, preventing the integration from being initialized and used.
💡 Suggested Fix
Restore the Sentry import statement in the Supabase integration code example. Consider using PlatformSection components to provide platform-specific imports (e.g., @sentry/node, @sentry/deno) for broader compatibility.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location:
docs/platforms/javascript/common/configuration/integrations/supabase.mdx#L42-L54
Potential issue: The code example for Supabase integration in
`docs/platforms/javascript/common/configuration/integrations/supabase.mdx` (lines 42-54)
is missing the `import * as Sentry from '@sentry/browser';` statement. This omission
causes any code following the example to throw a `ReferenceError: Sentry is not defined`
when `Sentry.init()` or `Sentry.supabaseIntegration()` are called, preventing the
integration from being initialized and used.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed to showcase how to setup the supabase integration.
DESCRIBE YOUR PR
Exposes the
supabaseIntegrationdocs for deno, cloudflare and react-native. Also cleaned up the snippet to not be browser-specific.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Closes: #15396