Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(node): Clarify usage of onFatalError option in node #2643

Merged
merged 3 commits into from
Nov 3, 2020
Merged

ref(node): Clarify usage of onFatalError option in node #2643

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7618d18
ref(node): Clarify usage of onFatalError option in node
kamilogorek Nov 2, 2020
bae1950
Apply suggestions from code review
kamilogorek Nov 3, 2020
a610395
Apply suggestions from code review
kamilogorek Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/platforms/node/common/configuration/integrations/default-integrations.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ Available options:
_Import name: `Sentry.Integrations.OnUncaughtException`_

This integration attaches a global uncaught exception handler. It can be modified to provide a custom shutdown function.
The `onFatalError` option is meant to perform a cleanup before the process exits, not fully prevent it from exiting.

<Alert level="warning" title="Note">

Be aware that if you overwrite this setting, you will lose the default implementation, which handles draining queued events before exiting. If you want to see how it works in order to be able to recreate it in your code, see the implementation of the [`logAndExitProcess`](https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/handlers.ts) function.
kamilogorek marked this conversation as resolved.
Show resolved Hide resolved

</Alert>

Available options:

Expand Down