Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update attach-stacktrace default #2815

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

philipphofmann
Copy link
Member

The attach-stacktrace on the options is default on for Android, Apple, and Java. This is now updated for the docs.

@bruno-garcia did we also set the default to true for .NET? If so ping me, so I update the PR.

The attach-stacktrace on the options is default on for Android, Apple
and Java. This is now updated for the docs.
@philipphofmann philipphofmann requested a review from a team December 30, 2020 09:51
@vercel
Copy link

vercel bot commented Dec 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/9jwyas356/sentry.dev
✅ Preview: https://sentry-docs-git-fix-attach-stacktrace-default.sentry.dev

@philipphofmann philipphofmann self-assigned this Dec 30, 2020
@bruno-garcia
Copy link
Member

It's not yet: https://github.com/getsentry/sentry-dotnet/blob/fd271982fdceab2b2a0b4ac425bbf0b50c18db18/src/Sentry/SentryOptions.cs#L130

Thanks for checking. We'll change what stacktraces look like on v3.0 and it'll be quite a bit more expensive to build them (so they look legible), for that reason I want to test it out before setting it to true in there.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@philipphofmann philipphofmann merged commit ac49f3c into master Jan 4, 2021
@philipphofmann philipphofmann deleted the fix/attach-stacktrace-default branch January 4, 2021 07:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants