Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java SDK 4.0 Docs update #2833

Merged
merged 21 commits into from
Jan 28, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Jan 6, 2021

PR collecting all the changes in docs for Java SDK 4.0 containing the performance feature.

@vercel
Copy link

vercel bot commented Jan 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/pqe5yp3hi/sentry.dev
✅ Preview: https://sentry-docs-git-fork-maciejwalkowiak-gh-1151.sentry.dev

@maciejwalkowiak
Copy link
Contributor Author

cc @bruno-garcia

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
maciejwalkowiak and others added 3 commits January 12, 2021 16:46
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge after releasing and iterate from there.

@maciejwalkowiak
Copy link
Contributor Author

@marandaneto do you want to merge it after we release 4.0 Final, or after next alpha? If after 4.0 Final, I would also change here dependencies versions.

@marandaneto
Copy link
Contributor

@marandaneto do you want to merge it after we release 4.0 Final, or after next alpha? If after 4.0 Final, I would also change here dependencies versions.

let's do it now, version is gonna be 4.0.0-beta.1

@maciejwalkowiak
Copy link
Contributor Author

If we merge it now i believe official docs should link to latest stable..?

@marandaneto
Copy link
Contributor

If we merge it now i believe official docs should link to latest stable..?

the question is if the current code snippets would work on the latest stable or not.
as every performance or new transport docs page require Sentry SDK v4, we'd need to link to v4 for those specific pages, I'd keep the latest version for everything else

@maciejwalkowiak
Copy link
Contributor Author

To make our lives simpler, I changed versions everywhere to 4.0 and lets deploy docs once this is released.

@marandaneto marandaneto merged commit caf5692 into getsentry:master Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants