Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ref update next.js config #3472

Merged
merged 6 commits into from
Apr 28, 2021
Merged

feat: Ref update next.js config #3472

merged 6 commits into from
Apr 28, 2021

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Apr 27, 2021

This updates the next.js docs to tell our users they need to wrap API calls manually.

@vercel
Copy link

vercel bot commented Apr 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/DvjYvJJs9xGouiB38JXFSvQsnDM1
✅ Preview: https://sentry-docs-git-ref-next-js-server.sentry.dev

Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I'd use this syntax. Sentry.withSentry looks redundant, and withSentry says it all.

src/includes/getting-started-config/javascript.nextjs.mdx Outdated Show resolved Hide resolved
src/includes/getting-started-verify/javascript.nextjs.mdx Outdated Show resolved Hide resolved
import * as Sentry from '@sentry/nextjs';

const handler = async (req, res) => {
// throw new Error('API Test 4')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either specify what this code should do, or remove the comment imo

Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Co-authored-by: iker barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
@HazAT HazAT merged commit c7a17d2 into master Apr 28, 2021
@HazAT HazAT deleted the ref/next-js-server branch April 28, 2021 10:13
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants