-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update BrowserTracing import for tree shaking #4474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/DLZiKB3xHjCZ7sZzmcC7NqMWwjr2 |
dab5ebf
to
177c2f4
Compare
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think you missed one, though: https://sentry-docs-git-abhi-browser-tracing-docs.sentry.dev/platforms/javascript/performance/instrumentation/automatic-instrumentation/#tracingorigins
In getsentry/sentry-javascript#4204 we updated the `BrowserTracing` import in the JS SDK to be exported individually. We want users to use this individual import so that the other integrations are treeshaken. This patch updates our documentation to import `BrowserTracing` directly from `@sentry/tracing` instead of through the `Integrations` object, which hopefully should lead to a bundle size reduction for people.
177c2f4
to
8e22845
Compare
In getsentry/sentry-javascript#4204 we updated the
BrowserTracing
import in the JS SDK to be exported individually. We want users to use this individual import so that the other integrations are treeshaken. This patch updates our documentation to importBrowserTracing
directly from@sentry/tracing
instead of through theIntegrations
object, which hopefully should lead to a bundle size reduction for people.