Skip to content

Update BrowserTracing import for tree shaking #4474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Dec 8, 2021

In getsentry/sentry-javascript#4204 we updated the BrowserTracing import in the JS SDK to be exported individually. We want users to use this individual import so that the other integrations are treeshaken. This patch updates our documentation to import BrowserTracing directly from @sentry/tracing instead of through the Integrations object, which hopefully should lead to a bundle size reduction for people.

@AbhiPrasad AbhiPrasad requested review from lobsterkatie, a team and sl0thentr0py and removed request for a team December 8, 2021 14:11
@vercel
Copy link

vercel bot commented Dec 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/DLZiKB3xHjCZ7sZzmcC7NqMWwjr2
✅ Preview: https://sentry-docs-git-abhi-browser-tracing-docs.sentry.dev

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbhiPrasad and others added 2 commits January 31, 2022 12:01
In getsentry/sentry-javascript#4204 we updated
the `BrowserTracing` import in the JS SDK to be exported individually.
We want users to use this individual import so that the other
integrations are treeshaken. This patch updates our documentation to
import `BrowserTracing` directly from `@sentry/tracing` instead of
through the `Integrations` object, which hopefully should lead to
a bundle size reduction for people.
@lobsterkatie lobsterkatie force-pushed the abhi-browser-tracing-docs branch from 177c2f4 to 8e22845 Compare January 31, 2022 20:01
@lobsterkatie lobsterkatie enabled auto-merge (squash) January 31, 2022 20:02
@lobsterkatie lobsterkatie merged commit cfb86d2 into master Jan 31, 2022
@lobsterkatie lobsterkatie deleted the abhi-browser-tracing-docs branch January 31, 2022 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants