Skip to content

Move API SHA bump to its own script #5151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

chadwhitacre
Copy link
Member

Overloading the bump-version.sh Craft hook to also be used from localhost during more-frequent API doc updates added some inter-environment friction that resulted in a CalVer release failure.

Seems great to update the API docs more frequently than once a month, and that means it would be redundant to also do this during monthly CalVer release, so let's move that to a separate script.

We are now updating the API docs SHA much more frequently than monthly,
so let's decouple it from the monthly Craft version bump.
@vercel
Copy link

vercel bot commented Jun 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs 🔄 Building (Inspect) Jun 16, 2022 at 3:00PM (UTC)

@chadwhitacre chadwhitacre changed the title Split version script into two Move API SHA bump to it's own script Jun 16, 2022
@chadwhitacre chadwhitacre requested review from wmak and JoshFerge June 16, 2022 15:00
@chadwhitacre chadwhitacre changed the title Move API SHA bump to it's own script Move API SHA bump to its own script Jun 16, 2022
@chadwhitacre chadwhitacre enabled auto-merge (squash) June 16, 2022 15:01
chadwhitacre added a commit to getsentry/develop that referenced this pull request Jun 16, 2022
@chadwhitacre chadwhitacre merged commit f9a5ab3 into master Jun 16, 2022
@chadwhitacre chadwhitacre deleted the cwlw/split-version-scripts branch June 16, 2022 15:02
@chadwhitacre
Copy link
Member Author

Oh geez automerge in repo w/ no branch protection. 🤦‍♂️

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Jun 16, 2022

Ftr here's where the API SHA bump was added to bump-version.sh.

chadwhitacre added a commit to getsentry/develop that referenced this pull request Jun 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant