-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(svelte): Add documentation for component tracking #5470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'd like to review this for style and wording once the technical review is complete. Can you please tag me when it's ready for that? |
@imatwawana I think the technical aspect is pretty clear. It's probably more in wording and placement so I think you're good to take a look now, if that's ok. (should have tagged you from the start, sry about that) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some wording suggestions. Otherwise, looks good. You said you didn't like the position of this content; I'm curious where do you think it should live?
src/platforms/javascript/guides/svelte/features/componenttracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/svelte/features/componenttracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/svelte/features/componenttracking.mdx
Outdated
Show resolved
Hide resolved
Thinking we should update the platform icon for Svelte to reflect the Svelte logo. Do you know how to do this? |
It looks like the Svelte logo was added to the platformicons, but I think it may have been added incorrectly. I'll check into that. You can ignore my comment. |
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
As always, thanks for your great review and suggestions @imatwawana
So my main hunch here is that we document the same feature (component tracking) very differently:
I would propose to rename the "Components" page in Angular and React to "Angular/React Features" and to try to make the naming as similar as possible. I understand that we need to find a middle ground because we can't only talk about component tracking in the docs, while the SDK code still uses terms like "tracing" and "profiling". WDYT, does this make sense? |
@Lms24 I like this idea. Is there anyone else we need buy-in from before making changes like these? |
@imatwawana apologies for getting back to this only now but I was OOO until today. I think overall, we don't need a lot of buy-in but I'll tag @AbhiPrasad as he has created component tracking for React. Abhi, do you think the proposed consolidation/unification of how we document component tracking would be a good idea? (I'll open an issue if we wanna move forward with this) |
Yeah I like this idea, let's move forward with it! |
Great! I extracted an issue from the description above: #5582 |
This PR adds a page in the Svelte SDK documentation about a new feature in the SDK, component tracking. It includes a brief description of what this feature does and how to use it (two ways).
I'm not particularly happy with the placement of the documentation but I took what we have in Angular and React as an example. In the future I'd vote to rename the navigation item on the left for Angular and React from "Components" to "[Framwork] Features". This title is IMO more general and better represents what's in there than "Components". In Angular for instance, none of the trace helpers are actual components. If we do this, we should also consider to adapt the Vue documentation which doesn't have such a section but scatters its component tracking documentation in the performance monitorin setup and router instrumentation pages.
ref: getsentry/sentry-javascript#5573