-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for AggregateErrors in Node.js and Browser #7499
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
} | ||
``` | ||
|
||
Here is a code example of how this could be implemented: | ||
|
||
<PlatformContent includePath="configuration/linked-errors" /> | ||
|
||
Additionally, the `LinkedErrors` integration enhances the capturing of [AggregateErrors](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) by recursively iterating over the `errors` property on Error objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, the `LinkedErrors` integration enhances the capturing of [AggregateErrors](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) by recursively iterating over the `errors` property on Error objects. | |
This integration also captures [AggregateErrors](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) by recursively iterating over the `errors` property on Error objects. |
Does this reword make sense? This sentence didn't make sense to me as written. Does iterating over the errors
property mean that the integration won't use the given key to recurse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this up higher, above available options, so it's not missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this reword make sense? This sentence didn't make sense to me as written. Does iterating over the errors property mean that the integration won't use the given key to recurse?
I originally had something similar but I was actually very specific with my wording because this integration doesn't capture any errors. It just enhances already captured error events with additional data.
Could we move this up higher, above available options, so it's not missed?
For sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, I see.
Maybe we could phrase it more like how you explained it to me here then:
Additionally, the `LinkedErrors` integration enhances the capturing of [AggregateErrors](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) by recursively iterating over the `errors` property on Error objects. | |
This integration also enhances captured error events with data from an [AggregateError](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) where applicable, by recursively iterating over the `errors` property on Error objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! Thank you! :)
src/platforms/node/common/configuration/integrations/default-integrations.mdx
Outdated
Show resolved
Hide resolved
@@ -42,6 +42,8 @@ Available options: | |||
} | |||
``` | |||
|
|||
Additionally, the `LinkedErrors` integration enhances the capturing of [AggregateErrors](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) by recursively iterating over the `errors` property on Error objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
…ntegrations.mdx Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Documents changes from getsentry/sentry-javascript#8463 where we implemented support for AggregateErrors in the JS SDK.