Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): Add meta instructions. #8452

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Conversation

onurtemizkan
Copy link
Collaborator

Adds meta function instructions for Distributed Tracing back.

Also, includes changes in the open PR getsentry/sentry-javascript#9493

Needs updates depending on that.

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:37pm

@shanamatthews
Copy link
Contributor

Hey @onurtemizkan - tag me when this is ready for review and I'll make sure it get's reviewed for ya!

@onurtemizkan
Copy link
Collaborator Author

Hey @shanamatthews, getsentry/sentry-javascript#9493 is merged and this is now ready for reviews!

@onurtemizkan onurtemizkan marked this pull request as ready for review November 10, 2023 10:45
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from me. @AbhiPrasad - could you review this for accuracy too?

Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@shanamatthews shanamatthews enabled auto-merge (squash) November 16, 2023 22:40
@shanamatthews shanamatthews merged commit 4057f3d into master Nov 16, 2023
7 checks passed
@shanamatthews shanamatthews deleted the onur/remix_meta_instructions branch November 16, 2023 22:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants