Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(astro): Improve Getting Started introduction #8685

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 11, 2023

This PR refactors the Astro "Getting Started" intro section. I tried the suggested "ramp" approach for docs. Figured as Astro is new and relatively small it's ideal to experiment with. Feel free to close this PR if you wanna tackle this more generally. Appreciate feedback either way.

image

Motivation for this change: Other than the meeting last week, we had users writing in (example) about Cloudflare and Edge support and it seemed like our previous compatibility note didn't state clearly enough that these runtimes are currently not supported.

Note: I also wanted to add numbering to the steps but this requires more fundamental changes to the common "getting started" template and I want to avoid this for now. IMO we should get rid of this common template. It's full of special cases already and I don't think we benefit much from it anymore. Probably collides with the rewrite anyway...

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 2:07pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 2:07pm

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE these updates!

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small tweak to fit our tab name convention.

@Lms24 Lms24 force-pushed the lms/ref-astro-compatibility branch from f477c92 to c1bf889 Compare December 18, 2023 13:41
@Lms24 Lms24 self-assigned this Dec 18, 2023
@Lms24 Lms24 merged commit 3ba0757 into master Dec 18, 2023
9 checks passed
@Lms24 Lms24 deleted the lms/ref-astro-compatibility branch December 18, 2023 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants