-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(astro): Improve Getting Started introduction #8685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
lizokm
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOVE these updates!
src/platform-includes/getting-started-primer/javascript.astro.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-primer/javascript.astro.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-primer/javascript.astro.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-primer/javascript.astro.mdx
Outdated
Show resolved
Hide resolved
shanamatthews
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small tweak to fit our tab name convention.
src/platform-includes/getting-started-install/javascript.astro.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.astro.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.astro.mdx
Outdated
Show resolved
Hide resolved
Lms24
force-pushed
the
lms/ref-astro-compatibility
branch
from
December 18, 2023 10:03
4cbb7fe
to
f85972b
Compare
Lms24
force-pushed
the
lms/ref-astro-compatibility
branch
from
December 18, 2023 13:41
f477c92
to
c1bf889
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Astro "Getting Started" intro section. I tried the suggested "ramp" approach for docs. Figured as Astro is new and relatively small it's ideal to experiment with. Feel free to close this PR if you wanna tackle this more generally. Appreciate feedback either way.
Motivation for this change: Other than the meeting last week, we had users writing in (example) about Cloudflare and Edge support and it seemed like our previous compatibility note didn't state clearly enough that these runtimes are currently not supported.
Note: I also wanted to add numbering to the steps but this requires more fundamental changes to the common "getting started" template and I want to avoid this for now. IMO we should get rid of this common template. It's full of special cases already and I don't think we benefit much from it anymore. Probably collides with the rewrite anyway...