Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cocoa app launch profiling #8876

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Jan 13, 2024

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 5:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 5:16am

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@armcknight
Copy link
Member Author

Please hold this PR until the SDK PR is merged: getsentry/sentry-cocoa#3529

@lizokm
Copy link
Contributor

lizokm commented Feb 2, 2024

Hey there, @armcknight! We've moved docs over to Next.js. If this PR is still relevant, could you rewrite it please? (Nothing has changed in the docs contribution process other than that we have to add images/PDFs to the"public" folder for them to be visible.) Thanks and sorry for the extra work!

@armcknight armcknight merged commit 2087d39 into master Feb 16, 2024
9 checks passed
@armcknight armcknight deleted the armcknight/feat/app-launch-profiling branch February 16, 2024 13:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants