Added the always_run option in excepthook document page #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
requested changes
May 13, 2019
src/collections/_documentation/platforms/python/default-integrations.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/platforms/python/default-integrations.md
Outdated
Show resolved
Hide resolved
|
@untitaker anything else? :) |
untitaker
requested changes
May 14, 2019
src/collections/_documentation/platforms/python/default-integrations.md
Outdated
Show resolved
Hide resolved
The learning process for me. I enjoy Review. :) I fixed it. @untitaker |
untitaker
approved these changes
May 14, 2019
|
I will merge this once a new version is released, because this repo deploys on merge. I hope to get to it within this week! Thanks so far. |
|
@MimiDumpling looping you in based on the meeting we just had. I want to make sure we figure out a process that is not too much friction on external contributors. |
| >>> raise Exception("I will become an error") | ||
| ``` | ||
|
|
||
| By default, the SDK does not capture errors occuring in the REPL (`always_run=False`). |
There was a problem hiding this comment.
Suggested change
| By default, the SDK does not capture errors occuring in the REPL (`always_run=False`). | |
| By default, the SDK does not capture errors occurring in the REPL (`always_run=False`). |
There was a problem hiding this comment.
ops, now fixing .. :) Bad typo
There was a problem hiding this comment.
No worries! This looks great. :) Thanks for all your work!
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getsentry/sentry-python#364
Is there wrong or missing piece?