Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop "Was this page Helpful to you" from floating around. #987

Closed
wants to merge 1 commit into from

Conversation

eurica
Copy link
Contributor

@eurica eurica commented May 16, 2019

I'm sure there's a better way to do it, but this will cause "Was this page Helpful to you" to stop following you around and only show at the bottom of the page.

Rational: it takes up space and adds minimal value.

@eurica eurica requested a review from cameronmcefee May 16, 2019 19:54
@cameronmcefee
Copy link
Contributor

cameronmcefee commented May 16, 2019

This particular approach creates undesirable layouts when the page is shorter than the viewport. I can make it work better if we really want to do this. However, this is done this way for a reason. Have you discussed this with @adhiraj first?

Screen Shot 2019-05-16 at 12 59 57 PM

@eurica
Copy link
Contributor Author

eurica commented May 16, 2019

It's not my top priority on the docs. We can wait until @adhiraj is back to understand what he's using it for.

@eurica eurica requested review from adhiraj and removed request for cameronmcefee May 16, 2019 20:03
@dcramer
Copy link
Member

dcramer commented May 16, 2019

Kind of wonder if we should just hide this. Once you X on it it never comes back so the current implementation feels like it falls short a bit anyways.

@adhiraj
Copy link
Contributor

adhiraj commented Jun 10, 2019

Once you X on it it never comes back

It actually comes back after 30m. That said, no one's using this data right now so I'd be ok completely removing it

@adhiraj
Copy link
Contributor

adhiraj commented Jul 1, 2019

bar is gone in #1086

@adhiraj adhiraj closed this Jul 1, 2019
@adhiraj adhiraj deleted the less-helpful branch July 1, 2019 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants