Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve React docs #999

Merged
merged 3 commits into from
May 24, 2019
Merged

feat: Improve React docs #999

merged 3 commits into from
May 24, 2019

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented May 22, 2019

No description provided.

@dcramer dcramer requested a review from MimiDumpling May 22, 2019 00:44
dcramer
dcramer commented May 22, 2019
View reviewed changes
src/collections/_documentation/platforms/javascript/react.md Outdated
@@ -4,17 +4,19 @@ sidebar_order: 30
---
<!-- WIZARD -->
To use Sentry with your React application, you will need to use `@sentry/browser` (Sentry’s browser JavaScript SDK).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would insert the install/configure instructions here, then error boundaries comes after they're fully setup

@dcramer
Copy link
Member Author

dcramer commented May 22, 2019

jsx support doesnt seem to exist/work

image

image

@dcramer
Copy link
Member Author

dcramer commented May 22, 2019

image

@dcramer
Copy link
Member Author

dcramer commented May 22, 2019

Updated to remove version

@dcramer
Copy link
Member Author

dcramer commented May 22, 2019

Jk my jsx is wrong

@dcramer
Copy link
Member Author

dcramer commented May 22, 2019

To me this is an improvement if I stumble upon the React page itself, but something we should decide broadly: do we embed the setup docs on every framework, or should we just have a generic entry blurb that directs them to the core JavaScript setup. In some framework cases the setup will change so it can still make sense.

@dcramer
Copy link
Member Author

dcramer commented May 22, 2019

Also trying to figure out how react.md can just include browsernpm.md to avoid copypasta, but it seems include_relative doesn't work based on the child file, but only the root template being rendered.

@dcramer dcramer merged commit 5ff338c into master May 24, 2019
@dcramer dcramer deleted the feat/improve-react-docs branch May 24, 2019 20:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cameronmcefee cameronmcefee cameronmcefee left review comments

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

@MimiDumpling MimiDumpling Awaiting requested review from MimiDumpling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcramer @cameronmcefee @evanpurkhiser