-
-
Notifications
You must be signed in to change notification settings - Fork 5
Implemented 'Extras' to 'User' #32
Implemented 'Extras' to 'User' #32
Conversation
@wuh95 could you please rebase with master to fix the appveyor build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wuh95 Thanks a lot for helping!
I just left a couple comments to align with other SDKs, etc.
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 94.54% 94.61% +0.06%
==========================================
Files 26 26
Lines 623 631 +8
==========================================
+ Hits 589 597 +8
Misses 34 34
Continue to review full report at Codecov.
|
Splitted 'Other' into internal and public Updated Unit Tests
It seems like there is another error in the appveyor build now |
@wuh95 right! It's fine this build will break when trying to upload artifacts to zeus.ci but the built itself is OK so I can merge it. |
@bruno-garcia When should I expect the merge? Because I want to use this change right away in my project :) |
@wuh95 I can merge it today but there's only small point above to change. Could you please fiz that last one? |
@bruno-garcia I overlooked that one, sorry. Everything should be right now :) |
@wuh95 great! Thanks. |
Ok, thank you! |
#31