Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Implemented 'Extras' to 'User' #32

Merged
merged 6 commits into from
Jan 25, 2019

Conversation

wuh95
Copy link

@wuh95 wuh95 commented Jan 22, 2019

#31

@bruno-garcia
Copy link
Member

@wuh95 could you please rebase with master to fix the appveyor build?

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuh95 Thanks a lot for helping!
I just left a couple comments to align with other SDKs, etc.

src/Sentry.Protocol/User.cs Outdated Show resolved Hide resolved
src/Sentry.Protocol/User.cs Outdated Show resolved Hide resolved
src/Sentry.Protocol/User.cs Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #32 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   94.54%   94.61%   +0.06%     
==========================================
  Files          26       26              
  Lines         623      631       +8     
==========================================
+ Hits          589      597       +8     
  Misses         34       34
Impacted Files Coverage Δ
src/Sentry.Protocol/User.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debc4e3...c8e7c7d. Read the comment docs.

Splitted 'Other' into internal and public
Updated Unit Tests
@wuh95
Copy link
Author

wuh95 commented Jan 23, 2019

It seems like there is another error in the appveyor build now

@bruno-garcia
Copy link
Member

bruno-garcia commented Jan 23, 2019

@wuh95 right! It's fine this build will break when trying to upload artifacts to zeus.ci but the built itself is OK so I can merge it.

@wuh95
Copy link
Author

wuh95 commented Jan 25, 2019

@bruno-garcia When should I expect the merge? Because I want to use this change right away in my project :)

@bruno-garcia
Copy link
Member

@wuh95 I can merge it today but there's only small point above to change. Could you please fiz that last one?
I'll publish a new version today.

@wuh95
Copy link
Author

wuh95 commented Jan 25, 2019

@bruno-garcia I overlooked that one, sorry. Everything should be right now :)

@bruno-garcia bruno-garcia merged commit d2da218 into getsentry:master Jan 25, 2019
@bruno-garcia
Copy link
Member

@wuh95 great! Thanks.
I'll publish a new version but I won't release Sentry yet so please make a direct reference to Sentry.Protocol using the new version.

@wuh95
Copy link
Author

wuh95 commented Jan 25, 2019

Ok, thank you!

@wuh95 wuh95 deleted the feature/add-extra-to-user branch January 25, 2019 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants