Process isolation for cache directory #1095
Closed
+116
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1095 +/- ##
==========================================
- Coverage 80.70% 80.43% -0.27%
==========================================
Files 194 195 +1
Lines 6359 6405 +46
Branches 1411 1417 +6
==========================================
+ Hits 5132 5152 +20
- Misses 764 790 +26
Partials 463 463
Continue to review full report at Codecov.
|
|
How the fuck did this pass the tests |
| options.CacheDirectoryPath, | ||
| "Sentry", | ||
| options.Dsn?.GetHashString() ?? "no-dsn" | ||
| ) | ||
| : throw new InvalidOperationException("Cache directory is not set."); | ||
|
|
||
| _processingDirectoryPath = Path.Combine(_isolatedCacheDirectoryPath, "__processing"); | ||
| _isolatedCacheDirectoryPath = Path.Combine( |
There was a problem hiding this comment.
Possibly an opt-out of this extra complexity given it isn't needed in mobile environments
| { | ||
| public static int GetCurrentProcessId() | ||
| { | ||
| using var process = Process.GetCurrentProcess(); |
There was a problem hiding this comment.
Doesn't work on IL2CPP so we might need to swap out in that environment with some P/Invoke.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067