Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL TFMs #3807

Merged
merged 15 commits into from
Dec 10, 2024
Merged

Drop support for EOL TFMs #3807

merged 15 commits into from
Dec 10, 2024

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Dec 2, 2024

@jamescrosswell jamescrosswell marked this pull request as ready for review December 5, 2024 11:24
@jamescrosswell jamescrosswell requested a review from vaind December 5, 2024 19:55
CHANGELOG.md Outdated Show resolved Hide resolved
test/Sentry.Log4Net.Tests/Sentry.Log4Net.Tests.csproj Outdated Show resolved Hide resolved
test/Sentry.Serilog.Tests/IntegrationTests.verify.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the integration test needs an update though:

/Users/runner/.dotnet/packs/Microsoft.Android.Sdk.Darwin/34.0.145/tools/Xamarin.Installer.Common.targets(12,3): error : Failed to locate Android SDK at path `/Users/runner/Library/Android/sdk`. [/Users/runner/work/sentry-dotnet/sentry-dotnet/integration-test/maui-app/maui-app.csproj::TargetFramework=net8.0-android34.0]
    0 Warning(s)
    4 Error(s)

Time Elapsed 00:00:05.12

Describing MAUI
Error: [-] Describe MAUI failed
Message
  RuntimeException: Failed to install android dependencies.
  at <ScriptBlock>, /Users/runner/work/sentry-dotnet/sentry-dotnet/integration-test/cli.Tests.ps1:153

@@ -2,7 +2,7 @@

<PropertyGroup>
<!-- TODO check and update the list of supported frameworks. -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- TODO check and update the list of supported frameworks. -->

@jamescrosswell
Copy link
Collaborator Author

Failed to install android dependencies

From what I can tell, this is an intermittent failure:

error : Failed to download Xamarin Repository manifest from https://aka.ms/AndroidManifestFeed/d17-12. System.AggregateException: One or more errors occurred. (The SSL connection could not be established, see inner exception.) [/Users/runner/work/sentry-dotnet/sentry-dotnet/integration-test/maui-app/maui-app.csproj::TargetFramework=net8.0-android34.0]

The aka.ms servers don't seem very reliable. On my Windows machine, I often have to run dotnet workload restore 3 to 4 times before it succeeds (regularly fails to validate the SSL certs).

@jamescrosswell jamescrosswell merged commit cb0a35c into main Dec 10, 2024
22 checks passed
@jamescrosswell jamescrosswell deleted the drop-eol-targets branch December 10, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop EOL targets
3 participants