-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL TFMs #3807
Conversation
This reverts commit a40baf0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, the integration test needs an update though:
/Users/runner/.dotnet/packs/Microsoft.Android.Sdk.Darwin/34.0.145/tools/Xamarin.Installer.Common.targets(12,3): error : Failed to locate Android SDK at path `/Users/runner/Library/Android/sdk`. [/Users/runner/work/sentry-dotnet/sentry-dotnet/integration-test/maui-app/maui-app.csproj::TargetFramework=net8.0-android34.0]
0 Warning(s)
4 Error(s)
Time Elapsed 00:00:05.12
Describing MAUI
Error: [-] Describe MAUI failed
Message
RuntimeException: Failed to install android dependencies.
at <ScriptBlock>, /Users/runner/work/sentry-dotnet/sentry-dotnet/integration-test/cli.Tests.ps1:153
@@ -2,7 +2,7 @@ | |||
|
|||
<PropertyGroup> | |||
<!-- TODO check and update the list of supported frameworks. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- TODO check and update the list of supported frameworks. --> |
From what I can tell, this is an intermittent failure:
The |
Resolves #3806: