-
-
Notifications
You must be signed in to change notification settings - Fork 227
Add SentrySdk.SetTag #4228 #4232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4232 +/- ##
==========================================
- Coverage 75.73% 73.07% -2.66%
==========================================
Files 357 456 +99
Lines 13466 16529 +3063
Branches 2671 3286 +615
==========================================
+ Hits 10198 12079 +1881
- Misses 2593 3609 +1016
- Partials 675 841 +166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you so much for adding this
I also added
SentrySdk.UnsetTag, because it feels closely related withSetTag.Some questions I had while implementing this:
Hub.ConfigureScopewraps the call toScopeManager.ConfigureScopein a try/catch, would that be appropriate for these methods too? E.g.PushScopedoesn't use a try/catch.sentry-dotnet/src/Sentry/Internal/Hub.cs
Lines 90 to 100 in aebd6a2
IHasTagswhich can set multiple tags at once. Does it make sense to add it toSentrySdktoo?sentry-dotnet/src/Sentry/IHasTags.cs
Line 33 in aebd6a2