Skip to content

fix: Unsampled spans no longer propagate empty trace headers #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2025
Merged

fix: Unsampled spans no longer propagate empty trace headers #4302

merged 3 commits into from
Jun 25, 2025

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Jun 24, 2025 •
edited
Loading

Resolves #4301:

This PR corrects two issues from separate comments:

  • One in the HttpContextExtensions (see comment)
  • One in the UnsampledSpan class (see comment)

@jamescrosswell jamescrosswell mentioned this pull request Jun 24, 2025
Closed
@jamescrosswell jamescrosswell marked this pull request as ready for review June 25, 2025 01:23
@jamescrosswell jamescrosswell merged commit 7707813 into main Jun 25, 2025
31 checks passed
@jamescrosswell jamescrosswell deleted the empty-trace-id branch June 25, 2025 01:24
This was referenced Jul 28, 2025
Closed
Closed
Closed
Open
This was referenced Aug 15, 2025
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
This was referenced Sep 8, 2025
Closed
Closed
Closed
Closed
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 2, 2025
Closed
Open
Closed
Closed
This was referenced Oct 15, 2025
Merged
Closed
Closed
This was referenced Nov 3, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@Flash0ver Flash0ver Awaiting requested review from Flash0ver Flash0ver is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update from 5.10 to 5.11.1 "cannot be empty (Parameter 'traceId')"

3 participants

@jamescrosswell @bruno-garcia