-
-
Notifications
You must be signed in to change notification settings - Fork 221
Backpressure #4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Backpressure #4452
Conversation
/// Enables or disables automatic backpressure handling. When enabled, the SDK will monitor system health and | ||
/// reduce the sampling rate of events and transactions when the system is under load. | ||
/// </summary> | ||
public bool EnableBackpressureHandling { get; set; } = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it eventually be 'true' by default or just while we validate it? if this is disabled forever by default it wont be of much value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the benefit mainly for Sentry here?
I think what the Java SDK did was have this optional initially, until they got some feedback from SDK users with high throughput scenarios, then they turned it on by default when they were happy with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with either .. enabling by default right away or later.
With net10.0
and our 6.0 Release on the horizon, we could do an opt-in for now, and enable per default in 6.0.
The "pain point" there is that we need to update the docs then again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an issue to make sure we circle back to this (by v6.0 at the latest):
Resolves #2410