Skip to content

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell marked this pull request as ready for review August 19, 2025 22:33
@jamescrosswell jamescrosswell self-assigned this Aug 19, 2025
cursor[bot]

This comment was marked as outdated.

/// Enables or disables automatic backpressure handling. When enabled, the SDK will monitor system health and
/// reduce the sampling rate of events and transactions when the system is under load.
/// </summary>
public bool EnableBackpressureHandling { get; set; } = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it eventually be 'true' by default or just while we validate it? if this is disabled forever by default it wont be of much value

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the benefit mainly for Sentry here?

I think what the Java SDK did was have this optional initially, until they got some feedback from SDK users with high throughput scenarios, then they turned it on by default when they were happy with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with either .. enabling by default right away or later.

With net10.0 and our 6.0 Release on the horizon, we could do an opt-in for now, and enable per default in 6.0.
The "pain point" there is that we need to update the docs then again.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an issue to make sure we circle back to this (by v6.0 at the latest):

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backpressure Management
4 participants