Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Oct 10, 2025

Resolves #4608

Not addressed in this PR

There are a couple of APIs left that are still marked as obsolete, which probably merit some discussion. I've created separate issues for these, so as not to block the work that has already been done in this PR.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (version6@90a3823). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             version6    #4619   +/-   ##
===========================================
  Coverage            ?   73.14%           
===========================================
  Files               ?      479           
  Lines               ?    17325           
  Branches            ?     3419           
===========================================
  Hits                ?    12672           
  Misses              ?     3804           
  Partials            ?      849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell jamescrosswell marked this pull request as ready for review October 10, 2025 09:18
@jamescrosswell
Copy link
Collaborator Author

@Flash0ver I think this PR turned out to be a bit too broad... so I created separate issues for all the unresolved discussions (see the PR description, linking to all of those).

That should hopefully unblock the work that's already been done here, which doesn't have any dependencies on those other things so no reason to force them all into the same change.

cursor[bot]

This comment was marked as outdated.

@jamescrosswell jamescrosswell merged commit 9d1b4fe into version6 Oct 16, 2025
30 checks passed
@jamescrosswell jamescrosswell deleted the obsolete-v6 branch October 16, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants