chore: Logging tweaks #4622
Merged
chore: Logging tweaks #4622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
requested review from
Flash0ver and
jamescrosswell
as code owners
Closed
Contributor
Author
|
Ahh tests.. checking for exact log message matches.. lemme fix that. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## version6 #4622 +/- ##
===========================================
Coverage ? 73.09%
===========================================
Files ? 479
Lines ? 17386
Branches ? 3432
===========================================
Hits ? 12709
Misses ? 3818
Partials ? 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, but the inconsistency has been bothering me when there are multiple logs in a row and they are only almost formatted the same. We've got the pattern of surrounding IDs with
''almost everywhere. I just added it to where I found it missing.Same with instances of ending sentences without a
..#skip-changelog