Skip to content

Disable sentry-native for WASM applications #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

Disable sentry-native for WASM applications #4631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8988b
Disable sentry-native for WASM applications
jamescrosswell Oct 14, 2025
6c4f4bd
changelog
jamescrosswell Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### Fixes

- The SDK avoids redundant scope sync after transaction finish ([#4623](https://github.com/getsentry/sentry-dotnet/pull/4623))
- sentry-native is now automatically disabled for WASM applications ([#4631](https://github.com/getsentry/sentry-dotnet/pull/4631))
Copy link
Member

@Flash0ver Flash0ver Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is this clearer?

Suggested change
- sentry-native is now automatically disabled for WASM applications ([#4631](https://github.com/getsentry/sentry-dotnet/pull/4631))
- sentry-native is now disabled per default for WASM applications ([#4631](https://github.com/getsentry/sentry-dotnet/pull/4631))

Which phrasing is conveying more clearly, that we disable it per default, but it could still be manually enabled?

On the other hand, it doesn't really make sense to manually enable sentry-native for Blazor-WASM.
I actually do prefer now as-is ... but wanted to keep the comment anyway.


## 6.0.0-preview.1

Expand Down
2 changes: 2 additions & 0 deletions src/Sentry/Platforms/Native/buildTransitive/Sentry.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
<FrameworkSupportsNative Condition="'$(RuntimeIdentifier)' == 'osx-x64' or '$(RuntimeIdentifier)' == 'osx-arm64'">true</FrameworkSupportsNative>
<!-- net8.0 or greater -->
<FrameworkSupportsNative Condition="'$(_SentryIsNet8OrGreater)' != 'true' or !('$(OutputType)' == 'Exe' or '$(OutputType)' == 'WinExe')">false</FrameworkSupportsNative>
<!-- WASM -->
<FrameworkSupportsNative Condition="'$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true'">false</FrameworkSupportsNative>
Copy link

@cursor cursor bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: WASM Disable Condition Overrides User Setting

The WASM disabling condition for FrameworkSupportsNative is evaluated before the explicit user opt-in/opt-out. This allows users to override the WASM disable by setting SentryNative=true, potentially reintroducing build errors for WASM applications.

Fix in Cursor Fix in Web

Copy link
Collaborator Author

@jamescrosswell jamescrosswell Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was intentional yes...

<!-- Make it opt-in/out -->
<FrameworkSupportsNative Condition="'$(SentryNative)' == 'true' or '$(SentryNative)' == 'enable'">true</FrameworkSupportsNative>
<FrameworkSupportsNative Condition="'$(SentryNative)' == 'false' or '$(SentryNative)' == 'disable'">false</FrameworkSupportsNative>
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry/buildTransitive/Sentry.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<Error Text="Android projects using Sentry cannot build using AndroidEnableAssemblyCompression = false due to a Microsoft issue. Please follow https://github.com/dotnet/android/issues/9752" />
</Target>

<ItemGroup Condition="$([MSBuild]::IsOSPlatform('Windows'))">
<ItemGroup Condition="$([MSBuild]::IsOSPlatform('Windows')) AND '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'">
<!-- See: https://github.com/getsentry/sentry-dotnet/pull/4111 -->
<LinkerArg Include="/NODEFAULTLIB:MSVCRT" />
</ItemGroup>
Expand Down
Loading