ci: fix/set MtouchUseLlvm=false to speed up the macOS build

[jpnurmi]

Reduces the CI round-trip time from 2+ hours to less than 1 hour.

Samples

The iOS target platform check in samples/Directory.Build.props did not work as expected. Sentry.Samples.Ios and Sentry.Samples.Maui were built with MtouchUseLlvm=true. We can remove the redundant iOS target platform check because the property is only applicable to iOS, tvOS, and Mac Catalyst, and never enabled by default on Mac Catalyst.

MtouchUseLlvm

A boolean property that specifies whether AOT compilation should be done using LLVM.

Applicable to iOS, tvOS and Mac Catalyst projects.

Default:

• On iOS and tvOS: enabled for Release builds (where Configuration="Release").
• On Mac Catalyst: never enabled by default.

https://learn.microsoft.com/en-us/dotnet/ios/building-apps/build-properties#mtouchusellvm

Tests

The property was already set for Sentry.Maui.Device.IntegrationTestApp. Now, it is also set for Sentry.Maui.Device.TestApp and the dynamically created maui-app integration test.

See also

• iOS Release pipelines taking an hour dotnet/maui#25022
• Building a NET6/NET7 iOS project on agent M2 ARM 64 hangs/freezes dotnet/macios#17825

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (version6@382fa2e). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             version6    #4677   +/-   ##
===========================================
  Coverage            ?   73.16%           
===========================================
  Files               ?      480           
  Lines               ?    17354           
  Branches            ?     3424           
===========================================
  Hits                ?    12697           
  Misses              ?     3807           
  Partials            ?      850           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jamescrosswell]

Nice!