Skip to content

Conversation

@Flash0ver
Copy link
Member

During #4699 and #4700 I noticed that we were missing one assertion.

This is a follow-up to #4566.
In particular to keep SentryMauiStructuredLoggerProviderTests.cs in sync with:

capturedLog.TryGetAttribute("sentry.origin", out object? origin).Should().BeTrue();
origin.Should().Be("auto.log.extensions_logging");


#skip-changelog

@Flash0ver Flash0ver self-assigned this Nov 6, 2025
@Flash0ver Flash0ver added the Logs label Nov 6, 2025
@Flash0ver
Copy link
Member Author

@sentry review

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (version6@19a8c1a). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             version6    #4701   +/-   ##
===========================================
  Coverage            ?   73.17%           
===========================================
  Files               ?      480           
  Lines               ?    17422           
  Branches            ?     3437           
===========================================
  Hits                ?    12749           
  Misses              ?     3822           
  Partials            ?      851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flash0ver Flash0ver marked this pull request as ready for review November 7, 2025 10:03
@Flash0ver Flash0ver added the Tests label Nov 7, 2025
Copy link
Member

@alexsohn1126 alexsohn1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jamescrosswell jamescrosswell merged commit 9a5c3e0 into version6 Nov 10, 2025
31 checks passed
@jamescrosswell jamescrosswell deleted the logs/test-origin-maui branch November 10, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants