Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate trace headers #758

Merged
merged 16 commits into from
Jan 26, 2021
Merged

Integrate trace headers #758

merged 16 commits into from
Jan 26, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jan 22, 2021 •
edited
Loading

Related to #663

Note, this doesn't include auto instrumentation for ASP.net Core, but only the core parts. Adding the instrumentation later would be easy once these are in (and won't be a breaking change).

@Tyrrrz Tyrrrz added Feature New feature or request Sentry labels Jan 22, 2021
Tyrrrz
Tyrrrz commented Jan 22, 2021
View reviewed changes
@Tyrrrz Tyrrrz requested a review from bruno-garcia January 22, 2021 18:43
@Tyrrrz Tyrrrz marked this pull request as ready for review January 25, 2021 19:10
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Jan 25, 2021

@bruno-garcia should be final, please do a final review

bruno-garcia
bruno-garcia reviewed Jan 26, 2021
View reviewed changes
bruno-garcia
bruno-garcia approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some notes but it's good to merge. We can iterate with the other features etc.

@marandaneto marandaneto mentioned this pull request Jan 26, 2021
Closed
Tyrrrz and others added 3 commits January 26, 2021 17:49
@Tyrrrz @bruno-garcia
Update src/Sentry/SentryClient.cs
e08d6f7 
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@Tyrrrz
wip
a6ca3f2
@Tyrrrz
wip
17d2bb9
@Tyrrrz Tyrrrz enabled auto-merge (squash) January 26, 2021 16:15
@Tyrrrz Tyrrrz merged commit 281ed1d into main Jan 26, 2021
@Tyrrrz Tyrrrz deleted the trace-header branch January 26, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker left review comments

@marandaneto marandaneto marandaneto left review comments

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees
No one assigned
Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tyrrrz @untitaker @bruno-garcia @marandaneto