CI: Use volta-cli/action to use the correct node version (#609)

getsentry · Jan 6, 2023 · 34481a6 · 34481a6
1 parent 35bb8b4
commit 34481a6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 21 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -15,10 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: '14'
-          cache: 'yarn'
+      - uses: volta-cli/action@v3
       - name: Install
         run: yarn install
       - name: Build
@@ -41,10 +38,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: '14'
-          cache: 'yarn'
+      - uses: volta-cli/action@v3
       - run: yarn install
       - name: Run Linter
         run: yarn lint
@@ -60,10 +54,7 @@ jobs:
         os: [ubuntu-latest, macos-latest, windows-latest]
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: '14'
-          cache: 'yarn'
+      - uses: volta-cli/action@v3
       - run: yarn install
       - name: Run Unit Tests
         run: yarn test
@@ -81,10 +72,7 @@ jobs:
       ELECTRON_VERSION: ${{ matrix.electron }}
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: '14'
-          cache: 'yarn'
+      - uses: volta-cli/action@v3
       - uses: actions/cache@v2
         with:
           path: |

diff --git a/.github/workflows/new-versions-pr.yml b/.github/workflows/new-versions-pr.yml
@@ -10,9 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
-        with:
-          node-version: '14'
+      - uses: volta-cli/action@v3
       - run: yarn install
       - name: Update Versions
         run: yarn update-electron-versions

diff --git a/package.json b/package.json
@@ -103,7 +103,7 @@
     "yaml": "^1.10.2"
   },
   "volta": {
-    "node": "16.14.0",
+    "node": "18.12.1",
     "yarn": "1.22.17"
   }
 }
diff --git a/test/e2e/context.ts b/test/e2e/context.ts
@@ -179,7 +179,11 @@ export class TestContext {
 
   private _clearAppUserData() {
     for (const dir of getDeleteDirectories(this._appName)) {
-      rmSync(dir, { recursive: true, force: true });
+      try {
+        rmSync(dir, { recursive: true, force: true });
+      } catch (_) {
+        //
+      }
     }
   }
 }