Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] mod.require Webpack builds #241

Merged
merged 8 commits into from
Jul 14, 2020
Merged

[WIP] mod.require Webpack builds #241

merged 8 commits into from
Jul 14, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jul 9, 2020

Fixes #223
Fixes #183
Fixes #179
Fixes #142

This PR makes use of the module and browser field in the package.json so modern bundlers like webpack prefer it over main.

@HazAT HazAT self-assigned this Jul 9, 2020
@HazAT HazAT changed the title [WIP] Fix/webpack require [WIP] mod.require Webpack builds Jul 9, 2020
@HazAT HazAT requested a review from timfish July 9, 2020 11:44
timfish
timfish approved these changes Jul 10, 2020
View reviewed changes
Copy link
Collaborator

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HazAT HazAT merged commit 27f717d into master Jul 14, 2020
@HazAT HazAT deleted the fix/webpack-require branch July 14, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@HazAT @timfish