fix: Include sentry_key in ping URL so it does not end up in breadcrumbs
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Oct 13, 2022
| @@ -13,7 +13,7 @@ function getImplementation(): IPCInterface { | |||
|
|
|||
| logger.log('IPC was not configured in preload script, falling back to custom protocol and fetch'); | |||
|
|
|||
| fetch(`${PROTOCOL_SCHEME}://${IPCChannel.PING}`).catch(() => | |||
| fetch(`${PROTOCOL_SCHEME}://${IPCChannel.PING}/sentry_key`).catch(() => | |||
There was a problem hiding this comment.
Shouldn’t this be a query string and not part of the path?
There was a problem hiding this comment.
It doesn't matter since the fetch breadcrumb checking matches the entire url!
In the main process, the protocol handler returns an empty response for anything that isn't scope or event.
There was a problem hiding this comment.
We already use this to exclude event and scope messages but it was left off ping!
sentry-electron/src/renderer/ipc.ts
Line 27 in ffad61d
There was a problem hiding this comment.
Ahhhh I see, thanks for clarifying.
AbhiPrasad
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
fetchto communicate with the main process, we includesentry_keyin the URL so that it does not result in a fetch breadcrumb.It appears this was left off of the
ping"command" resulting in a breadcrumb!